Added support to install gems from private repositories.#20
Added support to install gems from private repositories.#20nikhil2611 wants to merge 7 commits intomainfrom
Conversation
Signed-off-by: nikhil2611 <ngupta@progress.com>
Signed-off-by: nikhil2611 <ngupta@progress.com>
Signed-off-by: nikhil2611 <ngupta@progress.com>
Signed-off-by: nikhil2611 <ngupta@progress.com>
c37807e to
402cba2
Compare
There was a problem hiding this comment.
need to confirm that using the format x-access-token wont expose the token in the verbose output or when the job runs with debug.
using the git config global affects all git operations for that run on the node
this could lead to the cloning of a private repo
need to check on the scoping of the GH_PRIVATE_REPO_TOKEN i dont think that has any scopes limiting it.
I think we should investigate on using something like a PAT token for a specific repo, that only allows read, and or configure bundler in the run with something specific like: `
bundle config set --local github.com "x-access-token:${{ secrets.GH_PRIVATE_REPO_TOKEN }}"
Which will set that at runtime during the bundle install.
Or we need to figure out a safer way to ship the private repos rubygem to a something thats accessible.
Signed-off-by: nikhil2611 <ngupta@progress.com>
Signed-off-by: nikhil2611 <ngupta@progress.com>
@sean-sype-simmons Yeah right that using |
Signed-off-by: nikhil2611 <ngupta@progress.com>
Thanks for that. We need to have a larger discussion on this. I believe these settings may be better in your own repo with an override setting. However, we dont want to be managing multiple PAT's. There has to be a better way forward on this. |
This pull request updates CI workflows to improve support for private repositories and private Ruby gems, as well as to test a custom SBOM workflow branch. The most important changes are grouped below.
Private repository and gem access:
.github/workflows/ci-main-pull-request.yml..github/workflows/sbom.yml, ensuring thatbundle installcan access private gem sources.SBOM workflow update:
.github/workflows/ci-main-pull-request.ymlto use a custom branch (nikhil/pull-private-gems-github-branch) of the shared SBOM workflow, likely for testing or to support private gem access.Description
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.