Skip to content

Conversation

@sanjain-progress
Copy link

@sanjain-progress sanjain-progress commented Oct 21, 2025

  • Added run-specs-ruby-3.4 test job to verify.pipeline.yml
  • Uses ruby:3.4 Docker image for testing
  • Ensures compatibility with Ruby 3.4 release
  • Remove require 'kconv' from winrm_base.rb. kconv was not actually used in the codebase and it's only imported without any use

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@sanjain-progress sanjain-progress requested review from a team as code owners October 21, 2025 18:41
- Added run-specs-ruby-3.4 test job to verify.pipeline.yml
- Uses ruby:3.4 Docker image for testing
- Ensures compatibility with Ruby 3.4 release

Signed-off-by: Sachin <sachin.jain@chef.io>
@sanjain-progress sanjain-progress force-pushed the sanjain/CHEF-15868/ruby_3.4 branch from 3b48c31 to 65481d1 Compare October 21, 2025 18:54
Added new pipeline step for Windows with Ruby 3.4 using rubydistros/windows-2019:3.4 image to ensure comprehensive testing across both Linux and Windows platforms with latest Ruby versions.

Signed-off-by: Sachin <sachin.jain@chef.io>
- kconv was not actually used in the codebase and it's only  imported without any use

Signed-off-by: Sachin <sachin.jain@chef.io>
@sanjain-progress sanjain-progress force-pushed the sanjain/CHEF-15868/ruby_3.4 branch from afeeb72 to f147957 Compare November 10, 2025 19:22
@sonarqube-for-infrastructure-prod

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants