Skip to content

WIP Fix multiple issues #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lbakerchef wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP Fix multiple issues #12

lbakerchef wants to merge 4 commits into from

Conversation

@lbakerchef
Copy link

@lbakerchef lbakerchef commented Dec 16, 2022 •
edited
Loading

Multiple issues:

  • won't compile
  • won't run eunit tests
  • rebar3 won't pull down dependencies (git:// protocols)
  • inconsistent deps e.g. ibrowse
  • old rebar3 version
$ ./rebar3 version
rebar 3.3.0 on Erlang/OTP 24 Erts 12.3.2.6
  • fails eunit tests
Finished in 8.350 seconds
145 tests, 5 failures
===> Error running tests

After rebar3 upgrade:

$ ./rebar3 version
rebar 3.20.0 on Erlang/OTP 24 Erts 12.3.2.6

More work needed...

@lbakerchef
git:// -> https://
c89d064 
Signed-off-by: Lincoln Baker <lbaker@chef.io>
@lbakerchef
rebar3 3.3.0 -> 3.20.0
d8d1f6c 
Signed-off-by: Lincoln Baker <lbaker@chef.io>
@lbakerchef
Update ibrowse, add envy.
858c8c4 
Signed-off-by: Lincoln Baker <lbaker@chef.io>
@lbakerchef
Fix compilation errors (add nowarn_export_all to tests)
91aad45 
Signed-off-by: Lincoln Baker <lbaker@chef.io>
@lbakerchef lbakerchef self-assigned this Dec 16, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lbakerchef added a commit to chef/opscoderl_wm that referenced this pull request Dec 16, 2022
@lbakerchef
TEMPORARY COMMIT point to webmachine fixes
dbc9e59 
remove this commit once the webmachine PR is merged.
chef/webmachine#12

Signed-off-by: Lincoln Baker <lbaker@chef.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lbakerchef lbakerchef

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lbakerchef