Conversation
This might fix windows xp 32 support, which was broken since at least 0.6.1, probably since 0.6.0.
|
I'm not inclined to support Windows XP since Microsoft dropped support in April. Are you using this in production? |
|
Nope, I had to downgrade to Puppet 3.6.2, which uses win32-eventlog 0.5.3. I will test it if that's a requirement to getting it accepted. Alternatively, someone suggested "calling RegOpenKeyEx with KEY_WOW64_64KEY", which, in addition to being more likely to work on Windows XP, also makes your code less stateful and thus more likely to be reentrant |
|
If RegOpenKeyEx with KEY_WOW64_64KEY is better, and it works, I'd be willing to merge such a patch! |
|
I've just hit this incompatibility, also. Can this change be merged? FWIW, XP is still widely used in production all over the place, and it's still supported by Microsoft. They just call it Windows Embedded POSReady 2009. It will continue to receive updates until 2019. |
|
@TomyLobo do you still need this? |
|
9 years later, Windows XP has been EOL for 10 years and needs to die, so I don't care :) |
These functions don't seem to exist on Windows XP 32 bit, rendering support for it, which was broken since at least 0.6.1, probably since 0.6.0.
It shouldn't affect Windows versions where those functions exist.
And those where they don't exist would not work with 0.6.0-0.6.2 anyway :)