Skip to content

Comments

Wrapped Wow64* in begin..rescue.#12

Open
TomyLobo wants to merge 1 commit intochef:mainfrom
TomyLobo:patch-1
Open

Wrapped Wow64* in begin..rescue.#12
TomyLobo wants to merge 1 commit intochef:mainfrom
TomyLobo:patch-1

Conversation

@TomyLobo
Copy link

These functions don't seem to exist on Windows XP 32 bit, rendering support for it, which was broken since at least 0.6.1, probably since 0.6.0.

It shouldn't affect Windows versions where those functions exist.
And those where they don't exist would not work with 0.6.0-0.6.2 anyway :)

This might fix windows xp 32 support, which was broken since at least 0.6.1, probably since 0.6.0.
@djberg96
Copy link
Collaborator

I'm not inclined to support Windows XP since Microsoft dropped support in April. Are you using this in production?

@TomyLobo
Copy link
Author

Nope, I had to downgrade to Puppet 3.6.2, which uses win32-eventlog 0.5.3.
That works until I need to upgrade Puppet for some reason.

I will test it if that's a requirement to getting it accepted.

Alternatively, someone suggested "calling RegOpenKeyEx with KEY_WOW64_64KEY", which, in addition to being more likely to work on Windows XP, also makes your code less stateful and thus more likely to be reentrant

@djberg96
Copy link
Collaborator

If RegOpenKeyEx with KEY_WOW64_64KEY is better, and it works, I'd be willing to merge such a patch!

@aogail
Copy link

aogail commented Jun 2, 2015

I've just hit this incompatibility, also. Can this change be merged?

FWIW, XP is still widely used in production all over the place, and it's still supported by Microsoft. They just call it Windows Embedded POSReady 2009. It will continue to receive updates until 2019.

See: https://support.microsoft.com/en-us/lifecycle/search/default.aspx?sort=PN&alpha=Windows%20Embedded%20POSReady&Filter=FilterNO

@jsvd jsvd mentioned this pull request Nov 3, 2015
@sean-sype-simmons
Copy link

@TomyLobo do you still need this?

@sean-sype-simmons sean-sype-simmons added the Status: Waiting on Contributor A pull request that has unresolved requested actions from the author. label Dec 10, 2024
@TomyLobo
Copy link
Author

9 years later, Windows XP has been EOL for 10 years and needs to die, so I don't care :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Waiting on Contributor A pull request that has unresolved requested actions from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants