fix: Fix opacity issue with transparent backgrounds #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed an issue where the `opacity` parameter was ineffective when no `background_image` was specified. This was because `chop_image_v2` was converting the shadow image to RGB format, discarding the alpha channel. Consequently, shadows appeared too dark when the background was transparent. 2. Introduced `chop_image_v3` which preserves alpha channel if no background image is specified. 3. Modified `DropShadowV3` to use `chop_image_v3` and pass flag about background presence. 4. This change ensures that opacity is correctly applied even with transparent backgrounds, resulting in more accurate and visually appealing shadow effects.
Author
|
@chflame163 Hello, can you review this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opacityparameter was ineffective when nobackground_imagewas specified. This was becausechop_image_v2was converting the shadow image to RGB format, discarding the alpha channel. Consequently, shadows appeared too dark when the background was transparent.chop_image_v3which preserves alpha channel if no background image is specified.DropShadowV3to usechop_image_v3and pass flag about background presence.