WIP: #281: Fixes for lists expansion operator (+=)#290
Open
USSX-Hares wants to merge 3 commits intochimpler:masterfrom
Open
WIP: #281: Fixes for lists expansion operator (+=)#290USSX-Hares wants to merge 3 commits intochimpler:masterfrom
+=)#290USSX-Hares wants to merge 3 commits intochimpler:masterfrom
Conversation
Contributor
Author
|
I've found that pyhocon's implementation of the operator According to https://hocon-playground.herokuapp.com/, the following configuration: d {
x = [1,2]
x += [3,4]
}resolves into the following: d {
x=[
1,
2,
[
3,
4
]
]
}@darthbear, what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Casuse
Actually, the
+=operator took the HOCON definition too literally.When the
x += ywas met, it created a substitution forx.Then, when the entire config is read, that substitution is applied at the exact name
x.However, if
xwas inside a dict object, thexwould not be resolved.Changes
+=operator now creates a smarter substitutionToDo:
+=in-place?