Skip to content

Conversation

@bl0x
Copy link

@bl0x bl0x commented Oct 8, 2021

I've got a new and shiny Cmod A7 to play with, so here ya go!

@bl0x bl0x force-pushed the cmod_a7_support branch 2 times, most recently from 09bc45a to 40fd613 Compare October 13, 2021 21:39
@WhiteNinjaZ
Copy link
Contributor

WhiteNinjaZ commented Oct 20, 2021

@bl0x It looks like you might have had a server timeout while CI was running. Try force pushing to your fork again.

@kgugala
Copy link
Member

kgugala commented Oct 20, 2021

@bl0x It looks like you might have had a server timeout while CI was running. Try force pushing to your fork again.

I have restarted the build. The issues seem to be caused by to small custom runner coordinator machine. We've bumped the machine parameters

Copy link
Member

@kgugala kgugala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bl0x you're examples don't seem to be built in the CI. The CI runs code snippets from the documentation - you need to add build guide for your examples into the docs

@bl0x
Copy link
Author

bl0x commented Nov 24, 2021

I've added the snippet to the docs.

@bl0x
Copy link
Author

bl0x commented Dec 10, 2021

@kgugala Am I still missing something to make this ready for merging?

@WhiteNinjaZ WhiteNinjaZ requested a review from kgugala December 10, 2021 23:48
bl0x added 2 commits January 24, 2022 02:54
Signed-off-by: Bastian Löher <b.loeher@gsi.de>
…tix 35T.

Signed-off-by: Bastian Löher <b.loeher@gsi.de>
@bl0x
Copy link
Author

bl0x commented Jan 24, 2022

@kgugala I can't accept or review the requested changes anymore. I did however add the documentation earlier. Checks seem to pass now.

@acomodi acomodi self-requested a review January 24, 2022 08:42
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bl0x thanks for this PR!

Everything is fine with CI. Counter tests have indeed run correctly for the CMOD A7.

The only thing missing is adding a mapping for the CMOD A7 board in the docs generation, or else an empty tab will appear in the readthedocs page (https://symbiflow-examples--190.org.readthedocs.build/en/190/building-examples.html#counter-test)

You should add the mapping here as done for the other boards.

Signed-off-by: Bastian Löher <b.loeher@gsi.de>
@bl0x
Copy link
Author

bl0x commented Jan 24, 2022

I've added the mapping. It would be nice, if the documentation (README?) would tell which changes are needed in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants