xc7: linux litex test: remove PCF and SDC and fix XDC constrs #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
mithro
reviewed
Jan 6, 2022
Contributor
mithro
left a comment
mithro
left a comment
There was a problem hiding this comment.
Can you make the .xdc file the exact output of LiteX?
Contributor
Author
|
@mithro At the moment, we need to post-process the XDC generated by LiteX to avoid having unrecognized commands which are not yet implemented in the yosys plugin. Examples of these commands are the IMO we may proceed by merging this PR, so we eliminate the confusion around which constraint file is to be used. |
Contributor
|
Please make sure there are bugs logged for each XDC command which doesn't work. My understanding was that we had full support for XDC needed for LiteX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #235 and #234 and supersedes #236
Signed-off-by: Alessandro Comodi acomodi@antmicro.com