Fix a lot of Scala compilation warnings #3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymcauley
force-pushed
the
fix-warnings
branch
from
a95e3d7 to
2ea5edf
Compare
Contributor
Author
|
Removed this change since it's not available on the version of Scala that runs in CI (2.13.12) diff --git a/src/main/scala/util/SimpleProduct.scala b/src/main/scala/util/SimpleProduct.scala
index 50e99307c..b3cbbeb00 100644
--- a/src/main/scala/util/SimpleProduct.scala
+++ b/src/main/scala/util/SimpleProduct.scala
@@ -20,7 +20,7 @@ trait SimpleProduct extends Product with Equals {
case _ => false
}
- override def hashCode: Int = scala.util.hashing.MurmurHash3.productHash(this)
+ override def hashCode: Int = scala.util.hashing.MurmurHash3.caseClassHash(this)This deprecation happened in Scala 2.13.17. |
Contributor
Author
|
@sequencer in case you have time to review this PR. |
jerryz123
approved these changes
Dec 22, 2025
Contributor
Author
|
Thanks for reviewing this @jerryz123! I now notice that the master branch is ahead of the dev branch. Should I re-target this to be on the master branch instead? |
These types were moved from the `chisel3.experimental` package to `chisel3` in chipsalliance/chisel#5099 (with the `chisel3.experimental` types being deprecated), so the wildcard import causes import-conflict errors on Chisel 7.5.0.
tymcauley
force-pushed
the
fix-warnings
branch
from
2ea5edf to
d9bbb50
Compare
Contributor
Author
|
@jerryz123 Okay rebased on master, and targeted to merge there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a lot of compilation warnings, and also fixes compilation for Chisel 7.5.0 (due to the import conflict introduced by chipsalliance/chisel#5099).
Related issue: N/A
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Resolve Scala compilation warnings