Merged
Conversation
Check if Docker image exists locally via inspect_image() before attempting to pull from registry, avoiding unnecessary network requests.
Update all call sites of run_job() to match the new signature that groups related parameters into tuples: - (workflow_name, workflow_folder, workflow_params) - (job, config, job_params)
Fix bug in TUI state.rs where workflow completion always sent JobStatus::Completed, even when a job had failed. Now correctly tracks workflow_failed flag and sends appropriate final status.
Previously run_job() always returned Ok(container_id) even when scripts failed with non-zero exit codes. The all_scripts_succeeded flag was only used for output collection, not the return value. Now run_job() returns Err(DockerError::ScriptExecutionFailed) when any script fails, properly stopping workflow execution instead of continuing to the next job.
Add startup update check that queries GitHub Releases API and prompts user to update if a newer version is available. Features: - Version comparison using semver - Interactive Y/N prompt - Automatic execution of install script on confirm - 2-second timeout for network requests - Graceful handling of network failures
When user declines an update prompt, show the available version in the TUI footer bar as '[Update: vX.X.X]' in magenta. This reminds users that an update is available without being intrusive.
- Run cargo fmt to fix formatting across workspace - Fix collapsible_if warnings in executor.rs and layout.rs - Fix needless_return warning in state.rs All CI checks now pass: - 23 job_config tests - 40 silva tests - clippy with -D warnings - cargo fmt --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.