Achieve 100% test coverage for array.js #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The accumulate utility in js-toolkit/fp/array.js was exported but never called in production code, causing 98.04% function coverage. Added tests that exercise the function to achieve 100% coverage. Also restored the function coverage threshold in bunfig.toml to 1.0.
This commit addresses exports from packages/js-toolkit/fp/ that were only used in test files: Deleted (not used in production): - accumulate: never used anywhere - data, toData: moved to test-utils.js (test fixture helpers) - membershipPredicate: now private (internal impl detail for memberOf/notMemberOf) - filterObject: now private (internal impl detail for pickTruthy/pickNonNull) Extended test-only-exports check: - Now checks packages/js-toolkit/fp/*.js files for test-only exports - Added PACKAGES_FP_FILES pattern to test-utils.js - Added PACKAGES_ALL_FILES for import analysis (includes code-quality utilities) - omit is allowlisted since it's used via relative import in scanner.js The principle: code should not exist just for testing. Test utilities belong in test-utils.js, not in the production library.
- SRC_JS_FILES now includes both src/ and packages/js-toolkit/ (excluding test-utils/), covering all production code in one pattern - Add SRC_ONLY_JS_FILES for src/-specific style enforcement (array-push, comment-limits, function-length, object-mutation) - Remove PACKAGES_JS_FILES (redundant with unified SRC_JS_FILES) - Simplify test-only-exports.test.js to use unified SRC_JS_FILES - Fix type generator to handle rich-text fields (returns string, not unknown) - Update line number in ALLOWED_MUTABLE_CONST for test-utils.js
- Remove SRC_ONLY_JS_FILES (packages follows same rules as src) - Refactor packages/js-toolkit/code-quality/*.js to comply: - Remove excessive inline comments (limit: 5) - Refactor long functions into smaller helpers - Replace .push() with functional patterns (flatMap, filter) - Replace object mutation with Object.assign in reduce - Use optional chaining - Update line number in ALLOWED_MUTABLE_CONST for test-utils.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accumulate utility in js-toolkit/fp/array.js was exported but never called in production code, causing 98.04% function coverage. Added tests that exercise the function to achieve 100% coverage.
Also restored the function coverage threshold in bunfig.toml to 1.0.