Updates Docs and Self-Signed Certificate Generation of DatabaseCredential #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the initialize script was being run as a self-signed environment, it wasn't correctly generating and storing the DatabaseCredential. This caused a prompt, later in the install flow, to enter a credential. This change ensures that instead of checking for a ParameterSetName (which isn't set when no parameters are passed), it generates a credential if one is not provided already.
Logs were being clogged with progress reports.
Member
ryanrichter94
left a comment
ryanrichter94
left a comment
There was a problem hiding this comment.
Lines 79 and 80 can be removed from the README.md as you've put them in a separate offline install section of Step 1. Also, change line 81 to reference that people should proceed to the offline install section of Step 1.
ryanrichter94
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR introduces a few changes, including:
Motivation and Context
Feedback came after a PR was merged.
Testing
Operating Systems Testing
Change Types Made
[ ] Feature / Enhancement (non-breaking change).[ ] Breaking change (fix or feature that could cause existing functionality to change).Change Checklist
[ ] Tests to cover my changes, have been added.[ ] PowerShell code changes: PowerShell v3 compatibility checked?Related Issue
Fixes #296