fixed a mistake in get_dL(...) definition in spherical.c#1
Open
AnthonyKirilov wants to merge 1 commit intochomps:masterfrom
Open
fixed a mistake in get_dL(...) definition in spherical.c#1AnthonyKirilov wants to merge 1 commit intochomps:masterfrom
AnthonyKirilov wants to merge 1 commit intochomps:masterfrom
Conversation
get_dL function is declared and called with 3 arguments (see Hydro/euler_sph.c or Hydro/euler_sph3d.c) but it is defined with 4 in spherical.c. I removed the extra 'double dx' argument in the definition which is not used in the function anyway. This usually compiles without warning (because C...) and does not seem to cause runtime errors because 'dx' is not used in the function and 'dim' is the first and only integer in the parameter list and there is only one integer in the argument list. Nonetheless, this is still technically considered undefined behaviour that should be avoided - perhaps it could cause compile time or run time errors if one is using a different compiler, arch, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_dL function is declared and called with 3 arguments (see Hydro/euler_sph.c or Hydro/euler_sph3d.c) but it is defined with 4 in spherical.c. I removed the extra 'double dx' argument in the definition which is not used in the function anyway. This usually compiles without warning (because C...) and does not seem to cause runtime errors because 'dx' is not used in the function and 'dim' is the first and only integer in the parameter list and there is only one integer in the argument list. Nonetheless, this is still technically considered undefined behaviour that should be avoided - perhaps it could cause compile time or run time errors if one is using a different compiler, arch, etc.