xdrill functions for contract events#4
Closed
chowbao wants to merge 1 commit into5552/xdrill-changesfrom
Closed
Conversation
chowbao
commented
Jan 30, 2025
| "encoding/json" | ||
| "fmt" | ||
|
|
||
| "github.com/chowbao/go-stellar-xdr-json/xdr2json" |
Owner
Author
There was a problem hiding this comment.
TODO: move xdr2json to it's own repo stellar/stellar-rpc#350
chowbao
commented
Jan 30, 2025
| return contractIDString, true, nil | ||
| } | ||
|
|
||
| func Topics(d xdr.DiagnosticEvent) ([]interface{}, error) { |
Owner
Author
There was a problem hiding this comment.
Opted to pass in the event like with the go/ingest/ledger xdrill LCM functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
https://github.com/stellar/go/issues/5570
xdrill functions for diagnostic/contract events
Why
Create low level helper functions for diagnostic/contract events
Known limitations