Introduced Runner API for cleaner client embedding#27
Open
karlseguin wants to merge 1 commit intochristopherhesse:masterfrom
viki-org:runner
Open
Introduced Runner API for cleaner client embedding#27karlseguin wants to merge 1 commit intochristopherhesse:masterfrom viki-org:runner
karlseguin wants to merge 1 commit intochristopherhesse:masterfrom
viki-org:runner
Conversation
…Exp) *Rows. Exp.Run
now expects a Runner rather than a concrete *Session).
The purpose is to allow clients to cleanly embed Session (say to provide connection pooling):
type WrappedSession struct {
*rethinkgo.Session
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced Runner interface which exposes a single method: Run(query Exp) *Rows. Exp.Run
now expects a Runner rather than a concrete *Session).
The purpose is to allow clients to cleanly embed Session (say to provide connection pooling):
type WrappedSession struct {
*rethinkgo.Session
}
Without the interface, you'd need to use
wrapper.Sessioneverywhere. With it, you can simply usewrapper.