Remove filesize; use local formatter for upload progress#399
Open
FenPWysocki wants to merge 1 commit intochromaui:nextfrom
Open
Remove filesize; use local formatter for upload progress#399FenPWysocki wants to merge 1 commit intochromaui:nextfrom
FenPWysocki wants to merge 1 commit intochromaui:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace filesize with a tiny in-repo utility formatBytesObject() to format bytes and keep aligned units in upload progress.
Changes
Behavior
Uses SI units (B, kB, MB, …) with base 1000 and 1-decimal rounding; preserves aligned-unit display (e.g., “1.2/3.4 MB”). No locale or bits support.
Impact
Smaller dependency footprint; tiny risk of minor formatting differences vs filesize on edge cases.
Verification
Local typecheck and build pass; no runtime logic changed beyond formatting. Optional: run tests (npm test).