Mark IneligibleDomainState.Scans as noindex #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some writes of IneligibleDomainStates are failing with an error of: failed: datastore: datastore: datastore: datastore: string property too long to index for a Property with Name "Message" at index 0 for a Property with Name "Errors" for a Property with Name "Issues" at index 1 for a Property with Name "Scans"` Setting `noindex` (see https://pkg.go.dev/cloud.google.com/go/datastore@v1.20.0#hdr-Properties) on the Scans field should resolve this issue. We never query based on the Scans field, so not indexing it should be fine.
jdeblasio
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some writes of IneligibleDomainStates are failing with an error of:
failed: datastore: datastore: datastore: datastore: string property too long to index for a Property with Name "Message" at index 0 for a Property with Name "Errors" for a Property with Name "Issues" at index 1 for a Property with Name "Scans"`
Setting
noindex(see https://pkg.go.dev/cloud.google.com/go/datastore@v1.20.0#hdr-Properties) on the Scans field should resolve this issue. We never query based on the Scans field, so not indexing it should be fine.