Skip to content

PEO-834 | Fill rails code quality checking section #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Bulatkin wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

PEO-834 | Fill rails code quality checking section #147

Bulatkin wants to merge 4 commits into from

Conversation

@Bulatkin
Copy link

@Bulatkin Bulatkin commented Apr 15, 2020 •
edited
Loading

JIRA ticket: https://garage.atlassian.net/browse/PEO-834

Description

  • Filled rails code quality checking section

Before submitting the merge request make sure the following are checked

  • Followed the style guidelines of this project
  • Performed a self-review of own code
  • Wrote the tests that prove that fix is effective/that feature works

Notable changes

  • Added rails_best_practices to outputter quality section
  • Filled code quality checking section template

@Bulatkin Bulatkin self-assigned this Apr 15, 2020
@chubchenko chubchenko added the HOLD The merge request is put on hold label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Bulatkin Bulatkin

Labels

HOLD The merge request is put on hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Bulatkin @chubchenko @rostikkkk2 @Ahontic