Rise if Redis is not async #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nottezz
commented
Oct 30, 2025
| ttl: float, expect_error: Type[BaseException] | None | ||
| ) -> None: | ||
| mock_redis = AsyncMock() | ||
| mock_redis = AsyncMock(spec=AsyncRedis) |
Collaborator
Author
There was a problem hiding this comment.
Я тут задумался о том, что бы убрать моки и гонять тесты, развёртывая реальный Редис в контейнере, Action такое предоставляет.
Сложность будет в том, что локально тоже надо будет запускать у себя контейнер что б тесты не фейлились.
chud0
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Если мы передаём не async Redis, то получаем непонятную ошибку:
Причём ошибка проявляет себя лишь когда мы уже откроем страницу, на моменте запуска всё будет хорошо.
Теперь же ошибка появляется на самом старте и объясняется:
