Skip to content

Conversation

@dennisfeng200
Copy link
Collaborator

@dennisfeng200 dennisfeng200 commented Sep 4, 2024

The DynamicFormOrchestrator should be now in a working state for profile gen, which uses the "conversation_without_data" method. The "conversation_with_data" is in a working state, but I added TODO comments on possible improvements for the future if we want to build it out further.

Changes :

  • switched from requirements.txt file to using poetry files (pyproject.toml, poetry.lock). Note that we can run a CLI command to generate a requirements.txt file from the poetry.lock, if needed.
  • created DynamicFormOrchestrator and some pytests for it
  • modified Orchestrator to dump all env params in a 'env_params' attribute, which encapsulates the params better for DynamicFormOrchestrator
  • the Topic/ProfileMatchingUI branch was merged into this branch at an earlier point, in order to get some of the working frontend for testing here. Topic/ProfilingMatchingUI probably now has a lot more updates which I believe should overwrite the older commits here.
  • ...

Some features to point out that are NOT implemented, due to time constraint and priority:

  • for conversation_with_data: attaching a file is not supported, and cosmosDB data source is not supported (azure AI search is though!). These features probably won't be needed for profile gen chat.
  • when using conversation_without_data (the primary use case for profile gen), it is only programmatically guaranteed that 'dynamic_form_data' (in the HTTP response) exists as an object (of any type). There is NO guarantee that it matches the exact structure you defined in the prompt; that's a prompt engineering problem.

@dennisfeng200 dennisfeng200 marked this pull request as ready for review September 4, 2024 20:50
Copy link
Collaborator

@tendau tendau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot bring the GC specific UI into main. This either needs to live with the GC branch (deployment) or be pulled out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants