-
Notifications
You must be signed in to change notification settings - Fork 99
tetragon-reviewers: remove djalal from review team #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon-reviewers: remove djalal from review team #374
Conversation
joestringer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long do you think is reasonable for @tixxdz to see the notification? A week or so? Of course he can always self-nominate back in if he was taking an extended break and intends to continue.
nit: The linter fails, needs a fix.
Signed-off-by: Mahé <mahe.tardy@gmail.com>
LANG was ignored in some environment while LC_ALL should be respected. Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
1867d3e to
4dfd22c
Compare
I contacted him by email directly also without more success. Maybe we can wait one more week idk. |
kkourt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we wait one more week.
tixxdz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, approved as I won't really have time to review.
Most important: thank you very much @mtardy @joestringer @kkourt and all the team 🫡 ;-) !
Sorry was offline, answered. Much appreciated Mahé ;-) ! |
Hey,
I'm proposing to remove @tixxdz from the tetragon-reviewers team since we are using this team for the review rotation on tetragon and I'm not sure he wants to be asked to review on the project anymore. I'd like to have a confirmation from Djalal himself if he's still interested or not to continue to be part of the tetragon reviewers, I'm only suggesting since I see the review queue growing. I'd be happy if he wants to continue by the way.