shell: Port the shell package from cilium/cilium #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joamaki
force-pushed
the
pr/joamaki/shell
branch
from
e07c842 to
ff591c3
Compare
pippolo84
reviewed
Oct 9, 2025
Member
pippolo84
left a comment
pippolo84
left a comment
There was a problem hiding this comment.
Overall LGTM, some nits and cosmetic suggestions left inline
dylandreimerink
approved these changes
Oct 9, 2025
smagnani96
approved these changes
Oct 9, 2025
smagnani96
left a comment
smagnani96
left a comment
There was a problem hiding this comment.
LGTM, minor nit (Cilium reference in the code).
joamaki
force-pushed
the
pr/joamaki/shell
branch
8 times, most recently
from
0bf32c5 to
3fe7e53
Compare
bimmlerd
reviewed
Oct 21, 2025
joamaki
force-pushed
the
pr/joamaki/shell
branch
from
3fe7e53 to
893c9a1
Compare
Port over the shell server and client from cilium/cilium so it is easier to use in other projects. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Adapted from Dylan's prior work. Authored-by: Dylan Reimerink <dylan.reimerink@isovalent.com> Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com> Signed-off-by: Jussi Maki <jussi.maki@isovalent.com>
Add the shell server to the example application and add the shell command. To start the example application: go run ./example In another terminal connect to the example application shell: go run ./example shell Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/shell
branch
from
893c9a1 to
2c0f11f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's move the shell implementation into cilium/hive so it can be easily used in other projects as well.
The main changes from cilium/cilium:
Cellis nowServerCelland takes as argument the default path for the socketServerCellcreates its own job group. The providing ofjob.Groupas part ofcell.Moduleis only inpkg/hiveofcilium/cilium. Maybe should change that...ServerCellprints a info log message when it starts that includes the socket pathShellCmdnow takes the default socket path and a function to print the greetingSecond commit extends the
exampleapplication to add in the shell server and client.