Add the exit code on error #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc: @joamaki |
If the script command fails propagate the status with an error marker that is sent instead of the command end marker and use this to return an error in ShellExchange. With this the non-interactive use of the shell will exit with non-zero exit status on command failure, e.g. "cilium-agent shell -- unknown command" will exit with status 1. Signed-off-by: Vipul Singh <singhvipul@microsoft.com> Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
singhvipul/exit
branch
from
f18b10c to
32a0edb
Compare
Contributor
|
This was missing the propagation of the failure. Fixed this by adding a new marker ( |
joamaki
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the exit code when we see an error in executing a cmd in the shell.