Revert job lifecycle changes #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cec36a6.
This reverts commit 9741085.
This reverts commit 044838f. This change was incompatible with how Cilium implemented the operator leader lifecycle. This change causes jobs that should only start if elected leader to always be started since "wrong" lifecycle was used. We'll need to go back to drawingboard here. Signed-off-by: Jussi Maki <jussi@isovalent.com>
dylandreimerink
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #62 are incompatible with how jobs are used in the Cilium operator's
leader lifecycle construct. With this change jobs are tied to the lifecycle of the job.Registry which is not what we need
in the operator where we have two lifecycles. We'll need to rethink the design to allow the module-provided job.Group
in the operator to hook into the leader lifecycle instead of the root lifecycle.
As cilium/hive currently cannot be bumped in cilium/cilium let's revert the changes so that we're not blocking
other fixes.