Add support for IEEE 754 floats #225
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alex-ozdemir
left a comment
alex-ozdemir
left a comment
There was a problem hiding this comment.
Just one thought, so far.
* Introduced new optimization pass called Float * Extended IR with Op::FpToPf * Added new FP operations constants * visit function fully handles Op::Const * Op::Var is being worked on. Todo: * Implement all required hints and gadgets * Extend FLoatRewriter to handle lookups and table updates * Extend FloatRewriter to transform lookups into interactive proofs * Complete Op::Var case in visit fn before rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #223 by extending the IR to support IEEE 754 floats.
All the previously declared operators for floating-point numbers have been implemented, with a newly added operator called:
PfToFp, along with tests inir/term/test.rs.To do: