Skip to content

CRASM-3496/3499/3501 - Dependency upgrades to resolve vulnerabilities across application#1430

Merged
cduhn17 merged 6 commits intodevelopfrom
jb-upgrades-2025
Dec 31, 2025
Merged

CRASM-3496/3499/3501 - Dependency upgrades to resolve vulnerabilities across application#1430
cduhn17 merged 6 commits intodevelopfrom
jb-upgrades-2025

Conversation

@jayjaybunce
Copy link
Contributor

@jayjaybunce jayjaybunce commented Dec 30, 2025

🗣 Description

Due to each step in the effort to upgrade dependencies across the application leading to some level of breaking changes, all changes for the effort are within this PR to ensure we did not merge breaking changes into develop.

Changes (by ticket)
CRASM-3496
Upgraded Dockerfile.python base image from python:3.11-slim to python:3.12-slim-trixie. Resolves multiple vulnerabilities at the OS level of the backend docker containers
Upgraded Dockerfile.worker base image from python:3.11-bullseye to python:3.12-slim-trixie. Resolves multiple vulnerabilities at the OS level of the worker docker containers.
*There are multiple vulnerabilities within the Dockerfile.pe setup which are not addressed with these changes. We should look to update and test Dockerfile.pe build and functionality to use the python:3.12-slim-trixie, as it is currently using an older node base image.

CRASM-3499 - Resolve backend dependency vuln issues
Python Module Upgrade Table

Package Previous Version New Version
Cryptography 44.0.1 46.0.1
Django 5.2.8 5.2.9
elasticsearch 7.9.0 7.17.12
sqlparse 0.5.2 0.5.4
zipp 3.16.1 3.19.1
pshtt (internal fork and update) - -

CRASM-3501 - Resolve worker dependency vuln issues
Python Module Upgrade Table

Package Previous Version New Version
Cryptography 44.0.1 46.0.1
h11 0.14.0 0.16.0
requests 2.24.1 2.32.4
sslyze 5.2.0 6.2.0
zipp 3.16.1 3.19.1
mitmproxy 10.0.1 12.0.0

Dependabot Upgrades
Bump Django
Bump react-markdown

💭 Motivation and context

Contains changes which relate to the following tickets
CRASM-3496 => Resolve Docker images to Python 3.12
CRASM-3499 => Resolve backend dependency vulnerability issues
CRASM-3501 => Resolve worker dependency vulnerability issues

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@jayjaybunce jayjaybunce marked this pull request as ready for review December 31, 2025 15:01
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully addresses multiple security and stability concerns.

Security: The upgrades to sslyze, cryptography, and Django resolve known vulnerabilities.

Bug Fix: The fix for os.getenv in ecs_client.py prevents a definite runtime crash.

Compatibility: The logic updates in pshtt.py correctly handle the API changes in sslyze 6.x regarding hostname validation errors.

@cduhn17 cduhn17 merged commit 2a33829 into develop Dec 31, 2025
23 checks passed
@cduhn17 cduhn17 deleted the jb-upgrades-2025 branch December 31, 2025 19:46
@jayjaybunce jayjaybunce mentioned this pull request Jan 2, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants