Skip to content

Conversation

@syed-khadeerahmed
Copy link
Collaborator

@syed-khadeerahmed syed-khadeerahmed commented Jan 8, 2026

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Description

The PR has fix for 2 identified bugs in swim_workflow_manager

Bug Fix:

  1. [Swim]: Module fails to detect newly attached device tags due to the eventual consistency delay of the 'get_device_detail' API.
  2. [Swim]: Module still uses deprecated API '/dna/intent/api/v1/image/importation/golden' for Golden tag

Root Cause (if applicable): NA

Fix Implemented:

  1. Have changed APIs for device tags
  2. New APIs for tagging has been introduced with version control.

Enhancement: NA
Enhancement Description: NA
Impact Area: NA

Testing Done:

  • Manual testing
  • Unit tests
  • Integration tests

Test cases covered: [Mention test case IDs or brief points]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • All the sanity checks have been completed and the sanity test cases have been executed

Ansible Best Practices

  • Tasks are idempotent (can be run multiple times without changing state)
  • Variables and secrets are handled securely (e.g., using ansible-vault or environment variables)
  • Playbooks are modular and reusable
  • Handlers are used for actions that need to run on change

Documentation

  • All options and parameters are documented clearly.
  • Examples are provided and tested.
  • Notes and limitations are clearly stated.

Screenshots (if applicable)

Notes to Reviewers

family="software_image_management_swim",
function="remove_golden_tag_for_image",
function="get_golden_tag_status_of_an_image",
op_modifies=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to set op_modifies to get golden tag status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants