-
Notifications
You must be signed in to change notification settings - Fork 8
Feat/community closed message #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the `EventServiceState.closed` state to manage permanent connection termination scenarios, preventing unnecessary reconnection attempts.
Key Changes:
* **Events Service (`events.dart`):**
* Adds `EventServiceState.closed` to the enum.
* Modifies the connection error handling (`connect`) to check for a `WebSocketException` containing "404". If a 404 is detected, the service transitions to `closed` state and aborts reconnection.
* **Wallet Logic (`logic.dart`):**
* Adds a check in `handleInitialLoad` to immediately transition to `EventServiceState.closed` if the loaded `communityConfig.community.hidden` flag is true, preventing the service from attempting to connect to a hidden community.
* **UI Cleanup (`screen.dart`):**
* Removes unused state variable `eventServiceIntentionalDisconnect`.
* Updates logic to calculate `isClosed` based on the new state.
- Enhanced Drag-to-Dismiss Experience - Responsive Dragging - Smooth Snap-Back/Dismissal: - Reduced Dismissal Threshold: - Layout Fix
…nner text - Add optional 'meta' field to PluginConfig class to store custom metadata - Update CommunityClosedBanner to accept PluginConfig and use meta values - Support custom title, description, and button text from plugin meta - Refactor banner layout for improved centering and visual hierarchy - Remove Stack-based layout in favor of cleaner Column structure - Add SingleChildScrollView for better overflow handling - Fall back to localized text when meta values are not provided This enables communities to customize the closed banner messaging through the offboard plugin configuration without code changes.
Add new offboard plugin to wallet.pay.brussels community configuration to enable users to migrate their balance to the Citizen Pay App. The plugin launches a webview to the migration page with appropriate metadata including title, description, and button text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.