Skip to content

refactor(accounts): update getAllAccounts to return DBAccountV4 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SajeeTechi merged 1 commit into from
Dec 19, 2025
Merged

refactor(accounts): update getAllAccounts to return DBAccountV4 #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/services/accounts/accounts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ abstract class AccountsServiceInterface {
// key = wb_$wallet_address, value = $name|$privateKey

// get all accounts
Future<List<DBAccount>> getAllAccounts();
Future<List<DBAccountV4>> getAllAccounts();

// set account
Future<void> setAccount(DBAccount account);
Expand Down
4 changes: 2 additions & 2 deletions lib/services/accounts/native/android.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,8 @@ class AndroidAccountsService extends AccountsServiceInterface {

// get all wallet backups
@override
Future<List<DBAccount>> getAllAccounts() async {
final List<DBAccount> accounts = await _accountsDB.accounts.all();
Future<List<DBAccountV4>> getAllAccounts() async {
final List<DBAccountV4> accounts = await _accountsDB.accounts.all();

for (final account in accounts) {
final privateKey = await _credentials.read(account.id);
Expand Down
4 changes: 2 additions & 2 deletions lib/services/accounts/native/apple.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ class AppleAccountsService extends AccountsServiceInterface {

// get all wallet backups
@override
Future<List<DBAccount>> getAllAccounts() async {
final List<DBAccount> accounts = await _accountsDB.accounts.all();
Future<List<DBAccountV4>> getAllAccounts() async {
final List<DBAccountV4> accounts = await _accountsDB.accounts.all();

for (final account in accounts) {
final privateKey = await _credentials.read(account.id);
Expand Down
2 changes: 1 addition & 1 deletion lib/services/accounts/web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class WebAccountsService extends AccountsServiceInterface {

// get all wallet backups
@override
Future<List<DBAccount>> getAllAccounts() async {
Future<List<DBAccountV4>> getAllAccounts() async {
return [];
}

Expand Down
4 changes: 2 additions & 2 deletions lib/services/db/backup/accounts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,11 +317,11 @@ class AccountsTable extends DBTable {
await db.delete(name);
}

Future<List<DBAccount>> all() async {
Future<List<DBAccountV4>> all() async {
final List<Map<String, dynamic>> maps = await db.query(name);

return List.generate(maps.length, (i) {
return DBAccount.fromMap(maps[i]);
return DBAccountV4.fromMap(maps[i]);
});
}

Expand Down
Loading