Open
Conversation
The allowNumeric option allows numerical strings to be parsed, but there is no case to handle strings with mixed content. Consider how these strings are currently parsed: '123' -> 123 'abc123' -> Error '123abc' -> 123 In the third example the string is parsed as a number. This behaviour is okay but it would be good to also have the option to be strict about the full numeracy of the string. Enabling the fullNumberOnlyOption in conjunction with allowNumeric changes the mapping to this '19' -> 19 'a19' -> Error '19a' -> Error Code untested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowNumeric option allows numerical strings to be parsed, but there is no case to handle strings with mixed content.
Consider how these strings are currently parsed:
'123' -> 123
'abc123' -> Error
'123abc' -> 123
In the third example the string is parsed as a number. This behaviour is okay but it would be good to also have the option to be strict about the full numeracy of the string.
Enabling the fullNumberOnlyOption in conjunction with allowNumeric changes the mapping to this
'19' -> 19
'a19' -> Error
'19a' -> Error
Code untested.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: