User/tvandewalle/wol changes #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vdwtanner
commented
Jun 13, 2023
vdwtanner
commented
- Address feedback from User/tvandewalle/themes #9
- Warning message on status bar (used for Theme editing error messaging rather than obnoxious popups)
- Plugins can now specify DLLs to load from their plugin folder (system dlls should be loaded from within the plugin itself for now)
- Plugins now can request to be notified when the user stops typing (called during ConfirmEdits() )
- ConfirmEdits() now only called when typing characters specified in g_keyOutput. This prevents annoying warnings when deleting text
This is basically a shortcut to open a *.cmt file in the %APPDATA%/ColumnMode/Themes folder.
Some weirdness required due to dxcompiler.dll being a load time dependency of a plugin, but dxcompiler.dll does a check in dllmain to see if dxil.dll is loadable. It isn't in the default search path, so it silently decides to not load dxil.dll at runtime. FML.jpg Hacky solution is to load the plugin, get the dependency list, Free the plugin (which also frees dxcompiler.dll), THEN load the runtime dependency list, then RELOAD the plugin (which in turn loads its Load time dependencies, namely dxcompiler,dll). Now everyone is happy :) Hopefully no future plugin requires opposite behavior...
Collaborator
Author
|
Link to the HLSL shader toy plugin: https://github.com/vdwtanner/ColumnMode-HlslShaderToy Should probably add a README with basic build instructions, but basically create a build subdirectory and then do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.