Open
Conversation
angrave
reviewed
Oct 5, 2020
Collaborator
angrave
left a comment
angrave
left a comment
There was a problem hiding this comment.
Some things which seem to be missing here-
- Do we need to set the local directory, like the other containers, for persistent data
- Networking- This should be exposed to webapi and taskengine but presumably not the outside world
- Dependencies -we need to update the start up order/dependency?
- Logging options
@robkooper Rob can you help address these?
robkooper
requested changes
Oct 6, 2020
docker-compose.yml
Outdated
| container_name: elasticsearch | ||
| image: docker.elastic.co/elasticsearch/elasticsearch:7.6.2 | ||
| ports: | ||
| - 9200:9200 |
Contributor
There was a problem hiding this comment.
in general we don't want to expose ports, for local development this can be done using docker-compose.override.yaml.
| environment: | ||
| - xpack.monitoring.enabled=true | ||
| - xpack.watcher.enabled=false | ||
| - "ES_JAVA_OPTS=-Xms512m -Xmx512m" |
Contributor
There was a problem hiding this comment.
is this enough memory? How big will the index be, I think we should set Xmx to 2GB
docker-compose.yml
Outdated
| networks: | ||
| - elastic | ||
|
|
||
| kibana: |
Contributor
There was a problem hiding this comment.
is kibana needed? is there a way to prepopulate it with a username/password.
docker-compose.yml
Outdated
|
|
||
| networks: | ||
| elastic: | ||
| driver: bridge |
Contributor
There was a problem hiding this comment.
any reason for bridge network, also if we want the other containers to use this we should use the same network.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running this docker file should build elastic search server and kibana frontend