Skip to content

Add a build option for transparent background#47

Open
gpollo wants to merge 1 commit intoclbr:masterfrom
gpollo:master
Open

Add a build option for transparent background#47
gpollo wants to merge 1 commit intoclbr:masterfrom
gpollo:master

Conversation

@gpollo
Copy link

@gpollo gpollo commented Jun 29, 2017

This PR allows the user to build the application with background transparency using make transparent=1.

@clbr
Copy link
Owner

clbr commented Jun 29, 2017

Ncurses docs state that to use color -1, you must first call use_default_colors. I also think that this doesn't need to be an option at all, but replacing the BLACK color with -1 should work in most terminals.


start_color();
#ifdef ENABLE_TRANSPARENT
use_default_colors();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use_default_colors is being called here. And yeah, I don't really if it's a good thing to default to -1 tho.

@gpollo
Copy link
Author

gpollo commented Jun 29, 2017

After some testing, always enabling transparency works fine under TTY, but I believe it is a matter of taste whether one wants transparency (it just looked great with my background under X desktop).

@clbr
Copy link
Owner

clbr commented Jun 29, 2017

None of my terminals use compositing, and under all of them -1 is just the default bg color (black for all but xterm, which is white). So please make it the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants