Cleanup: removal of Analysis, addition of Statsample::Excel::parse #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Gemfile.lock from the repository
@clbustos agreed this change should be made in clbustos#11, but never merged it
Remove bad check in cronbach_alpha calculation
I mostly worked through whitespace issues and replaced some logic with `Enumerable` methods. And Rubocop's --auto-correct flag is wonderful.
Improve readability of lib/statsample.rb
This PR should move the dependencies from the Gemfile the configuration from the Rakefile (via Hoe) to statsample.gemspec. I still want to make sure that all the versions in the gemspec are correct and that I'm not forgetting anything before merging with master. Fix #14
Replace Hoe with gemspec
Also removed setup.rb (outdated and unnecessary given rubygems) and Manifest.txt (also unnecessary; we can use `git` to build it when packaging the gem). The gemspec changes reflect the README's.
I also removed the web/ directory. I'll provide some means of updating examples & documentation asap. Change VERSION to 1.4.2
Test on Ruby 2.2 and auto test on patched versions
Even Ruby 1.9 is EOL, thus no need to check for it.
- Removed the line converting everything to String (wtf). - Added a DEFAULT_OPTIONS constant.
Remove deprecated missing value functions
remove libgsl typo in Installation instructions
Regression with categorical data and introducing formula language
change DataFrame.to_hash -> .to_h in reliability.rb
apply appropriate hash conversions
update daru version
Update tested ruby version in README
Add Ruby 2.4 support
Don't define Array#sum if already defined. Fixes #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved Analysis to SciRuby.
Added a parse function for Statsample::Excel, which SciRuby now uses to read files it has already opened.