Add recipient and sender parameters for individual name parts #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mt-clearhaus
left a comment
mt-clearhaus
left a comment
There was a problem hiding this comment.
Great start! I've added some suggestions and comments.
I think a more appropriate PR title is "Add recipient and sender parameters for individual name parts".
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/debits/recipient_information.md
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/credits.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/debits/sender_information.md
Show resolved
Hide resolved
website/content/gateway/examples/payout_to_cardholder/payout_to_cardholder.md
Outdated
Show resolved
Hide resolved
cbobach
changed the title
Co-authored-by: Martin Toft Bay <mt@clearhaus.com>
Contributor
mt-clearhaus
left a comment
mt-clearhaus
left a comment
There was a problem hiding this comment.
A few additional comments 🙂
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
website/content/gateway/api_reference/resources/credits/recipient_information.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Toft Bay <mt@clearhaus.com>
Contributor
|
This looks very good to me 👍 We just need to set a date in the change entry. |
thejspr
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New name related parameters will be added:
recipient[first_name]recipient[middle_name]recipient[last_name]sender[first_name]sender[middle_name]sender[last_name]This will in time push for the deprecation of:
card[name]recipient[name]sender[name]We will in a grace period allow for both old and new parameters, but we recommend that you plan the shift as we can't guarantee how long our upstream provider supports the old fields.