local dev env setup process fixes #226
Open
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set docker to use yarn 4 so it does not default to yarn 1 update_build was refereing to 'gulp update' but update task is not defined, so i make it target build instead
…re copying package.json to prevent conflicts
…arn version management, preparing Yarn 4.12.0 for use.
…epack, ensuring compatibility with Yarn 4.12.0.
…atibility with Yarn 4.12.0.
…version management.
cbobach
requested changes
Jan 19, 2026
Contributor
cbobach
left a comment
cbobach
left a comment
There was a problem hiding this comment.
See my comments, especially the one for the build/start.sh script. That's the blocker I have. The rest is nice 🙇 💪
package.json
Outdated
| "serve": "gulp build && hugo server --source=website/ --bind=0.0.0.0", | ||
| "build": "gulp build", | ||
| "update_build": "gulp update", | ||
| "update_build": "gulp build", |
Contributor
There was a problem hiding this comment.
As gulp update isn't implemented and yarn update_build isn't used anywhere we could scrap this command and update the README.md to run docker exec -it gateway-api-docs yarn build instead of utilizing the yarn update_build command, which isn't implemented 🤷
Contributor
There was a problem hiding this comment.
Suggested change
| "update_build": "gulp build", |
And then update the README.md
thejspr
previously approved these changes
Jan 19, 2026
Contributor
thejspr
left a comment
thejspr
left a comment
There was a problem hiding this comment.
I've tested it locally and it works well
…README to simplify local serving instructions and modified start.sh to run the Docker container directly for serving the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed /build/start.sh — removed the nested Docker command
Set docker to use yarn 4 so it does not default to yarn 1 update_build was referring to 'gulp update' but update task is not defined, so i make it target build instead
Also force docker hub to use latest yarn version