This repository was archived by the owner on Aug 7, 2025. It is now read-only.
Fixups #1644
Merged
Fixups #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2025 08:31
Signed-off-by: William Douglas <william.douglas@intel.com>
In order to get the content needed for check-update with the --verbose option, root is required as data is put into the statedir. Keep the old behavior when verbose isn't passed. This was change was required because of the new latest file handling for --incremental. Signed-off-by: William Douglas <william.douglas@intel.com>
bryteise
force-pushed
the
fixups
branch
3 times, most recently
from
aeffe42 to
ab242a7
Compare
The current format is very useful information to get from bug reports so add it as default output to swupd update. Signed-off-by: William Douglas <william.douglas@intel.com>
bwarden
reviewed
Apr 24, 2025
Contributor
bwarden
left a comment
bwarden
left a comment
There was a problem hiding this comment.
In the updated test content, I found inconsistent escaping of parens in heredocs.
Contributor
Author
The cases where the parens are escaped are because the test uses a regex vs the other cases where it is using the exact strings so no escape is needed. |
bwarden
approved these changes
Apr 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.