fix(shared): use @clerk/ui package version for UI script URL #7418
+26
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughIntroduces a new global constant UI_PACKAGE_VERSION sourced from the UI package.json and propagated into TypeScript globals, build definitions, runtime code usage, and test setup; tests and URL construction were updated to use this UI-specific version. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (28)
Comment |
Why this change was needed: The clerkUiScriptUrl function was incorrectly using JS_PACKAGE_VERSION (from @clerk/clerk-js) as the fallback version when no explicit version was provided. This meant @clerk/ui scripts would be loaded using @clerk/clerk-js's version (e.g., @clerk/ui@5) instead of @clerk/ui's own version (e.g., @clerk/ui@0), causing potential version mismatches. What changed: Added UI_PACKAGE_VERSION build constant that reads from @clerk/ui's package.json and updated clerkUiScriptUrl to use it as the fallback instead of JS_PACKAGE_VERSION.
nikosdouvlis
force-pushed
the
nikos/fix-ui-pkg-version
branch
from
5cfc34e to
62ed71b
Compare
brkalow
approved these changes
Dec 9, 2025
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change was needed:
The clerkUiScriptUrl function was incorrectly using JS_PACKAGE_VERSION (from @clerk/clerk-js) as the fallback version when no explicit version was provided. This meant @clerk/ui scripts would be loaded using @clerk/clerk-js's version (e.g., @clerk/ui@5) instead of @clerk/ui's own version (e.g., @clerk/ui@0), causing potential version mismatches.
What changed:
Added UI_PACKAGE_VERSION build constant that reads from @clerk/ui's package.json and updated clerkUiScriptUrl to use it as the fallback instead of JS_PACKAGE_VERSION.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.