chore(deps): update kubernetes packages to v0.35.0 #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
3d93aa0 to
0b7b39f
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
0b7b39f to
0ee3531
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
0ee3531 to
daf4403
Compare
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
daf4403 to
c5a3397
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
c5a3397 to
7ffa6a3
Compare
renovate
bot
changed the title
Contributor
Author
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
7ffa6a3 to
b93d885
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/kubernetes-go
branch
from
b93d885 to
43b4951
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| golang.org/x/crypto v0.44.0 // indirect | ||
| golang.org/x/mod v0.29.0 // indirect | ||
| golang.org/x/net v0.47.0 // indirect |
There was a problem hiding this comment.
Bug: The code references podcmd.DefaultContainerAnnotationName, a constant removed in k8s.io/kubectl v0.35.0, which will cause a compilation failure.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The update to k8s.io/kubectl v0.35.0 causes a build failure because the code references an exported constant, podcmd.DefaultContainerAnnotationName, which has been removed in this new version. The code in internal/util/cmd_setup.go uses this constant to look up an annotation on a pod. Since the constant no longer exists, the Go compiler will raise an "undefined" error, preventing the application from being built.
💡 Suggested Fix
Replace the reference to the removed constant podcmd.DefaultContainerAnnotationName with its hardcoded string value, "kubectl.kubernetes.io/default-container". It is recommended to define this as a local constant within the package.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: go.mod#L144
Potential issue: The update to `k8s.io/kubectl v0.35.0` causes a build failure because
the code references an exported constant, `podcmd.DefaultContainerAnnotationName`, which
has been removed in this new version. The code in `internal/util/cmd_setup.go` uses this
constant to look up an annotation on a pod. Since the constant no longer exists, the Go
compiler will raise an "undefined" error, preventing the application from being built.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8119229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.33.3→v0.35.0v0.33.3→v0.35.0v0.33.3→v0.35.0v0.33.3→v0.35.0Release Notes
kubernetes/api (k8s.io/api)
v0.35.0Compare Source
v0.34.3Compare Source
v0.34.2Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
v0.33.7Compare Source
v0.33.6Compare Source
v0.33.5Compare Source
v0.33.4Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.35.0Compare Source
v0.34.3Compare Source
v0.34.2Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
v0.33.7Compare Source
v0.33.6Compare Source
v0.33.5Compare Source
v0.33.4Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.35.0Compare Source
v0.34.3Compare Source
v0.34.2Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
v0.33.7Compare Source
v0.33.6Compare Source
v0.33.5Compare Source
v0.33.4Compare Source
kubernetes/kubectl (k8s.io/kubectl)
v0.35.0Compare Source
v0.34.3Compare Source
v0.34.2Compare Source
v0.34.1Compare Source
v0.34.0Compare Source
v0.33.7Compare Source
v0.33.6Compare Source
v0.33.5Compare Source
v0.33.4Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.