Skip to content

Conversation

@pburkholder
Copy link
Contributor

Changes proposed in this pull request:

  • This is the first step, enabling
  • The configuring may be do-able by the customer via SQL scirpts

security considerations

[Note the any security considerations here, or make note of why there are none]

Copy link

@zjrgov zjrgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if I've missed it here or in the discussions otherwise but I was wondering: what sort of credentials are you using with the AWS CLI for this?

--tag-filters Key="Instance GUID",Values="$service_instance_guid" \
| jq -r '.ResourceTagMappingList[].ResourceARN' | grep -v replica )

# get AWS instancea name from ARN
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (non-blocking): on instances; vvv important, good thing I was curious about this PR so I could make this helpful feedback

Suggested change
# get AWS instancea name from ARN
# get AWS instances name from ARN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants