Skip to content

Fix missing TYPE value for ifcfg files #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BogdanEmilian wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix missing TYPE value for ifcfg files #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd1db6
Fix missing TYPE value for ifcfg files
BogdanEmilian Jan 22, 2026
f819fc1
Case sensitive and dict possible conflicts coverage
BogdanEmilian Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion coriolis/osmorphing/netpreserver/ifcfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ def _get_ifcfgs_by_type(self, ifcfg_type, network_scripts_path):
ifcfgs = []
for ifcfg_file in self._get_net_config_files(network_scripts_path):
ifcfg = self.osmorphing_tool._read_config_file_sudo(ifcfg_file)
if ifcfg.get("TYPE") == ifcfg_type:
detected_type = ifcfg.get('TYPE')
if not detected_type:
detected_type = "Ethernet"
ifcfg["TYPE"] = detected_type
if detected_type.lower() == ifcfg_type.lower():
ifcfgs.append((ifcfg_file, ifcfg))
return ifcfgs