Bugfix/semver lt #16
Open
Bugfix/semver lt #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 30, 2023 09:31
Use bash in shebang use [[ ]] for tests remove 'function' keyword Fix shellcheck errors and warnings
There was a bug in semverLT(), when both versions have a special field, semverLT would just compare that special field if majorA > majorB Before fix: ./semver.sh 8.4.2-12 6.90.5-13 8.4.2-12 -> M: 8 m:4 p:2 s:-12 6.90.5-13 -> M: 6 m:90 p:5 s:-13 8.4.2-12 == 6.90.5-13 -> 1. 8.4.2-12 < 6.90.5-13 -> 0. <- Offending result! 8.4.2-12 > 6.90.5-13 -> 1. <- Side effect because GT uses LT After fix: ./semver.sh 8.4.2-12 6.90.5-13 8.4.2-12 -> M: 8 m:4 p:2 s:-12 6.90.5-13 -> M: 6 m:90 p:5 s:-13 8.4.2-12 == 6.90.5-13 -> 1. 8.4.2-12 < 6.90.5-13 -> 1. <- Correct 8.4.2-12 > 6.90.5-13 -> 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bash in shebang
Fix shellcheck errors and warning
Fix a bug in semverLT:
There was a bug in semverLT(), when both versions
have a special field, semverLT would just compare
that special field if majorA > majorB
Before fix:
./semver.sh 8.4.2-12 6.90.5-13
8.4.2-12 -> M: 8 m:4 p:2 s:-12
6.90.5-13 -> M: 6 m:90 p:5 s:-13
8.4.2-12 == 6.90.5-13 -> 1.
8.4.2-12 < 6.90.5-13 -> 0. <- Offending result!
8.4.2-12 > 6.90.5-13 -> 1. <- Side effect because GT uses LT
After fix:
./semver.sh 8.4.2-12 6.90.5-13
8.4.2-12 -> M: 8 m:4 p:2 s:-12
6.90.5-13 -> M: 6 m:90 p:5 s:-13
8.4.2-12 == 6.90.5-13 -> 1.
8.4.2-12 < 6.90.5-13 -> 1. <- Correct
8.4.2-12 > 6.90.5-13 -> 0.