registry: Fixes to allow layer uploads above 5GB #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we need to copy a stream of the uploaded layer (random uuid) to a `blobs/.../<digest>` path, that might surpass the maximum size of a monolithic upload to R2 without using multipart uploads. To circumvent this, we will calculate the digest from the uploaded path and compare. Then, we will create a reference in the original `blobs/.../digest` path pointing to the upload path.
…an continue hashing from where we left it
Collaborator
Author
|
tests fail due to some random vitest stuff that ive yet to figure out. However, behavior looks ok to me from manual testing. Will fix tests tomorrow |
Contributor
|
This PR fix the 5GB size limit on my local tests ! Any update on this @gabivlj for merge soon ? |
gabrielrcom
approved these changes
Mar 6, 2025
Contributor
|
Pull Requests #100 and #101 should be merged in this PR first before merging to main branch. PS: The vitest error cmme from the direct import of serverless-registry/src/registry/r2.ts Line 37 in b740391 But i'm not sure how to fix it properly. |
Contributor
|
This PR is pending for more than a year... Anything missing ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we need to copy a stream of the uploaded layer (random uuid) to a
blobs/.../<digest>path, that might surpass the maximum size of a monolithic upload to R2 without using multipart uploads.To circumvent this, we will calculate the digest from the uploaded path and compare. Then, we will create a reference in the original
blobs/.../digestpath pointing to the upload path.Should fix #69