-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(vite-plugin-cloudflare): prevent interactive shortcuts in Turbo environment #11875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: eb613f7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @bxff, Thanks for the PR. If the root issue here is the tty, then I think it's better to check for that directly instead of checking for tooling specific environment variables. What do you think? |
|
@edmundhung Yeah, checking for tty makes more sense, fixed now. |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
@edmundhung fixed test that was failing due to TTY check. |
|
@edmundhung friendly bump, awaiting maintainer workflow approval. |
Fixes vercel/turborepo#11412.
The Cloudflare Vite Plugin's interactive shortcuts cause Miniflare
ERR_DISPOSEDerrors during TanStack Start prerendering under Turborepo. This adds a TTY check to prevent registering shortcuts in Turbo environments, resolving the runtime crash during the Vite preview server phase.