[workers-utils] Fix compat date resolution in workspaces #11910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a9be9bb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
approved these changes
Jan 14, 2026
Contributor
petebacondarwin
left a comment
petebacondarwin
left a comment
There was a problem hiding this comment.
Nice little trick!
Comment on lines
+12
to
+16
| // Note: this works because Wrangler depends on `miniflare` (and therefore `workerd`) | ||
| // in the monorepo. | ||
| const wranglerPackageJson = fileURLToPath( | ||
| new URL("../../wrangler/package.json", import.meta.url) | ||
| ); |
Contributor
There was a problem hiding this comment.
I'm a bit worried that this is brittle due to relying upon the relative location of the wrangler package compared to this file. But I guess it is only in a test and if it changes the test will break and we'll know to change it.
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getLocalWorkerdCompatibilityDate()could fail in workspaces because it usedrequire.resolve("miniflare"), andminiflare’smainpoints atdist/(which may not exist until built). That caused the function to fall back even thoughworkerdis installed.This change:
miniflare/package.jsoninstead, so resolution works even beforeminiflareis built@cloudflare/workers-utilsCommands run:
pnpm checkpnpm test:ci --filter @cloudflare/workers-utilsPublic documentation
A picture of a cute animal (not mandatory, but encouraged)
/_/\
( o.o )