Make memory_limit_bytes available as optional bosh property #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code allows both a configurable % and byte limit for memory. Specifically the byte limit makes sense when you want to run log-cache on a really large VM, colocated with other things, but you don't want it to take up too much of the VM's memory. This optional property will do nothing until set, at which point it will override the memory % limit, as documented.
|
|
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
Contributor
Author
|
/easycla |
chombium
approved these changes
Aug 29, 2025
Contributor
chombium
left a comment
chombium
left a comment
There was a problem hiding this comment.
Hi @dsboulder thanks for your contribution!
LGTM!
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Contributor
Author
|
Yay, it was fun to add something... even if it's tiny! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code allows both a configurable % and byte limit for memory. Specifically the byte limit makes sense when you want to run log-cache on a really large VM, colocated with other things, but you don't want it to take up too much of the VM's memory.
This optional property will do nothing until set, at which point it will override the memory % limit, as documented.
Type of change
Testing performed?
I validated the deployment with the property provided and saw that memory was kept under control to a small amount (tested with 10MB limit, saw log cache grow to ~30MB but then stop... I'm assuming that's a 10MB app logs limit not a total process limit)
I validated the deployment with the property missing and saw the BPM.yml was valid and no longer set the memory limit in bytes at all.
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack