Skip to content

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Nov 21, 2025

Description

Removes filtering of undefined properties as it does not add any value and may cause performance issues (see comment).

How has this been tested?

Tested changes locally.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll mxschll requested a review from cansuaa November 21, 2025 09:51
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (4950e94) to head (93a920a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4061      +/-   ##
==========================================
- Coverage   97.12%   97.12%   -0.01%     
==========================================
  Files         863      863              
  Lines       25295    25294       -1     
  Branches     9119     9119              
==========================================
- Hits        24567    24566       -1     
  Misses        722      722              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit a4c6954 Nov 21, 2025
50 checks passed
@mxschll mxschll deleted the dev-v3-schomax-refactor branch November 21, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants