Skip to content

Conversation

@SU-Cloudsmith
Copy link
Collaborator

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
cloudsmith-docs Ready Ready Preview, Comment Jan 20, 2026 1:44pm

Request Review

Copy link

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to strip the double quotes from the new token, as running jq '.data.key' will return "mytoken" (literally including the double qutoes). When we then export this to our env it'll still persist these quotes, so the token is invalid, and means the whoami will fail.

We need the -r flag for raw output, so it should be jq -r '.data.key'

One other suggestion might just be to add set -Eeuo pipefail at the top of the script to ensure we abort execution in the event something fails, rather than continuing to try the next commands.

Maybe worth mentioning that normal users will need to use cloudsmith login instead of cloudsmith auth? I know you already say that this uses SSO to login, but might be nice to mention that non-SAML users can still do this programmatically as long as they authenticate differently.

@paulmay-cloudsmith
Copy link
Collaborator

Can we please, never user the term "webapp".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants