Skip to content

Conversation

@colinmoynes
Copy link
Collaborator

@colinmoynes colinmoynes commented Jan 6, 2026

📄 Summary

Briefly describe the purpose of this pull request. What problem does it solve or feature does it add?

🔍 Related Issues

Link to any related GitHub issues (e.g., Fixes #12, Closes #34):

🧪 Type of Change

Please check the relevant type tag for this PR title:

  • [FIX] Bug fix
  • [NEW] New thing
  • [REFACTOR] Internal changes such as code restructuring or optimization that does not alter functionality
  • [DOC] Documentation-only changes
  • [CHORE] Maintenance, cleanup, or CI configuration

🧪 How Has This Been Tested?

Describe how you tested your changes. Include CI runs, local tests, manual verification, or screenshots if applicable.

📸 Screenshots (if applicable)

If UI or logs are affected, include before/after screenshots or output.

✅ Checklist

  • I’ve read and followed the CONTRIBUTING.md.
  • I’ve added or updated documentation as needed.
  • I’ve verified the change is tested and works as intended.
  • CI/CD checks pass and do not break existing functionality.
  • My code follows the style guidelines of this project.

@colinmoynes colinmoynes self-assigned this Jan 6, 2026
Copilot AI review requested due to automatic review settings January 6, 2026 16:05
@colinmoynes colinmoynes merged commit f02046f into main Jan 6, 2026
5 checks passed
@colinmoynes colinmoynes deleted the delete-validation-check branch January 6, 2026 16:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an interactive confirmation prompt for deletion operations in the Sonar Docker image inspector tool. The change improves safety by requiring explicit user confirmation before executing potentially destructive operations.

  • Adds interactive confirmation prompt for deletion operations (--untagged-delete, --delete-all, --delete-tag)
  • Introduces --force flag to bypass the confirmation prompt for automated workflows
  • Removes duplicate argument parser code block that existed in the main function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

console.print("[red] - Deleting: ALL detected manifest lists[/red]")
if args.delete_tag:
console.print(f"[red] - Deleting: Manifest lists with tag '{args.delete_tag}'[/red]")

Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected at the end of this line. Remove the extra spaces for cleaner code formatting.

Suggested change

Copilot uses AI. Check for mistakes.
args = parser.parse_args()
logger.info(f"Arguments: {args}")

# Interactive Confirmation for Deletion
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment above this block to explain the purpose of the interactive confirmation. For example: "Prompt user for confirmation before executing any deletion operations unless --force flag is provided."

Suggested change
# Interactive Confirmation for Deletion
# Prompt user for confirmation before executing any deletion operations unless --force flag is provided

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants