Skip to content

Conversation

@grkvlt
Copy link

@grkvlt grkvlt commented Oct 25, 2017

Upgrades to use Fabric 1.0.3 and Docker CE, and adds a development cluster application template to the catalog entries.

Copy link
Contributor

@drigodwin drigodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't seem to work, I've hit two initial problems. See comments.

@@ -1,70 +1,200 @@
brooklyn.catalog:
version: 0.18.0-SNAPSHOT # BROOKLYN_HYPERLEDGER_VERSION
version: 0.19.0-SNAPSHOT # BROOKLYN_HYPERLEDGER_VERSION
Copy link
Contributor

@drigodwin drigodwin Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to change the version you should use the change version script as you've missed a number of places such as here

Entities for running the Hyperledger Fabric project in Apache Brooklyn.
license_code: Apache-2.0
Entities for Hyperledger Fabric.
license_code: APACHE-2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a valid spdx code but the original was, see here. Note the same is true for other files in which this has been changed.

composer network deploy --archiveFile digitalPropertyNetwork.bna --enrollId WebAppAdmin --enrollSecret DJY27pEnl16d
composer network list -n digitalproperty-network --enrollId WebAppAdmin --enrollSecret DJY27pEnl16d

npm test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why run the tests here?

@@ -1,70 +1,200 @@
brooklyn.catalog:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This catalog.bom needs to be at the root of the project

echo "[HLF] docker installed"

customize.command: |
sudo tee /etc/docker/daemon.json <<EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file /etc/docker appears not to exist at this point

tee: /etc/docker/daemon.json: No such file or directory

Adding sudo mkdir -p /etc/docker before seems to fix this.

is.leader.node: true
latch.launch: $brooklyn:component("my-hyperledger-orderer-node").attributeWhenReady("service.isUp")
post.launch.command: |
sudo docker pull hyperledger/fabric-ccenv:${HYPERLEDGER_VERSION}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${HYPERLEDGER_VERSION} is not in the shell.env and so it produces the error invalid reference format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants